Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition to #846 and #855: #869

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Addition to #846 and #855: #869

merged 2 commits into from
Apr 18, 2018

Conversation

TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Apr 13, 2018 •
edited
Loading

Change list

  • OkHttpClient instead of ApacheHttpClient
  • fix of java.lang.IllegalArgumentException: Input byte array has incorrect ending byte at...

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

I could reproduce java.lang.IllegalArgumentException: Input byte array has incorrect ending byte at... on the getting of clipboard text

@TikhomirovSergey
Addition to #846 and #855:
3cc1ba6 
- OkHttpClient instead of ApacheHttpClient
- fix of java.lang.IllegalArgumentException: Input byte array has incorrect ending byte at...
@TikhomirovSergey
Copy link
Contributor Author

@SrinivasanTarget Could you check it on iOS?

SrinivasanTarget
SrinivasanTarget reviewed Apr 13, 2018
View reviewed changes
src/main/java/io/appium/java_client/clipboard/HasClipboard.java
@@ -72,7 +72,7 @@ default void setClipboardText(String text) {
*/
default String getClipboardText() {
byte[] base64decodedBytes = Base64
.getDecoder()
.getMimeDecoder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did suggested this in last PR. How did i missed it. Good catch @TikhomirovSergey

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach Last time when i locally built Appium's WDA(Forked) and tested clipboard of URL's where passing in iOS after your fix here but now i upgraded my XCUI driver to latest release but URL's stopped working after that.

URL's are working only if i use mime decoding for URL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make mime decoding for getClipboardUrl too? Else it is failing...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SrinivasanTarget Will make that today

@TikhomirovSergey
Addition to #846 and #855:
94aea3e 
- using of mime encoder/decoder
@TikhomirovSergey
Copy link
Contributor Author

@SrinivasanTarget I made some changes. Could you run iOS test one more time?

jlipps
jlipps approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. any chance we can publish a new beta?

@SrinivasanTarget SrinivasanTarget merged commit a542fee into appium:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@jlipps jlipps jlipps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TikhomirovSergey @jlipps @mykola-mokhnach @SrinivasanTarget